changes for package instead of module #57
Conversation
|
I did confirm with |
.github/workflows/release_gh.yml
Outdated
| @@ -17,3 +17,4 @@ jobs: | |||
| with: | |||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||
| upload-url: ${{ github.event.release.upload_url }} | |||
| package-prefix: adafruit_httpserver | |||
There was a problem hiding this comment.
This is really only used for unconventionally named libraries like asyncio which use import names that don't begin with adafruit_. Forcing it like this achieves the same thing down the line as leaving it out, hence how the mpy files are still gathered correctly as you mentioned - so there's no need for it :)
There was a problem hiding this comment.
removed this one with the latest commit.
|
I do intend to add a check to the build CI that checks whether a library should be a module or package and sees whether it is correctly labelled as such: adafruit/workflows-circuitpython-libs#22 |
Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.0.2 from 4.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#57 from FoamyGuy/package_changes Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
I think this should resolve: #56
I found these places to change by looking at the TODOs in a fresh cookie cutter library.
The release_gh.yml one I am less sure about. There was a TODO for it in the new template, but the released mpy files in this repo seem to have been generated correctly even without this change so I'm not sure whether it's actually needed here or not.