Remove secrets usage #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Feb 24, 2025
Co-authored-by: Dan Halbert <[email protected]>
|
@dhalbert there are 6 PRs that use |
dhalbert
requested changes
Feb 24, 2025
| @@ -354,7 +354,7 @@ class Cloud_Core: | |||
| """CircuitPython Google Cloud IoT Core module. | |||
|
|
|||
| :param ESP_SPIcontrol esp: ESP32SPI object. | |||
| :param dict secrets: Secrets.py file. | |||
| :param dict secrets: dictionary of settings. | |||
There was a problem hiding this comment.
Should this be renamed to settings?
There was a problem hiding this comment.
I thought about that, but if people are passing in named args it would break. If you are okay with that change, I'll totally update it.
There was a problem hiding this comment.
Since secrets.py is not mentioned, yes, seems like ok to call it secrets still.
dhalbert
approved these changes
Feb 25, 2025
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 26, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 9.0.1 from 9.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#217 from dhalbert/json-url Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 3.0.0 from 2.0.21: > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#28 from justmobilize/remove-secrets-usage Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 4.0.0 from 3.2.13: > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#30 from justmobilize/remove-secrets-usage Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 3.0.0 from 2.6.2: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#66 from justmobilize/remove-secrets-usage Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 3.0.0 from 2.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#20 from justmobilize/remove-secrets-usage Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 2.2.2 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#97 from FoamyGuy/use_ruff_remove_8x_compat Updating https://github.com/adafruit/Adafruit_CircuitPython_WSGI to 3.0.0 from 2.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_WSGI#23 from justmobilize/remove-secrets-usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of secrets and more:
secrets.pytoos.getenvESPSPI_WiFiManagertoWiFiManagers