Skip to content

Remove secrets usage #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Feb 24, 2025

Remove usage of secrets and more:

  1. change from using secrets.py to os.getenv
  2. switch from ESPSPI_WiFiManager to WiFiManager

@justmobilize justmobilize marked this pull request as ready for review February 24, 2025 23:30
@justmobilize
Copy link
Contributor Author

@dhalbert there are 6 PRs that use ESPSPI_WiFiManager and are the largest user of secrets in examples. This is 1 of them

@dhalbert dhalbert merged commit 1e6a1ab into adafruit:main Feb 25, 2025
1 check passed
@justmobilize justmobilize deleted the remove-secrets-usage branch February 25, 2025 03:08
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 26, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 9.0.1 from 9.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#217 from dhalbert/json-url

Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 3.0.0 from 2.0.21:
  > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#28 from justmobilize/remove-secrets-usage

Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 4.0.0 from 3.2.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#30 from justmobilize/remove-secrets-usage

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 3.0.0 from 2.6.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#66 from justmobilize/remove-secrets-usage

Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 3.0.0 from 2.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#20 from justmobilize/remove-secrets-usage

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 2.2.2 from 2.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#97 from FoamyGuy/use_ruff_remove_8x_compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_WSGI to 3.0.0 from 2.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_WSGI#23 from justmobilize/remove-secrets-usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants