-
Notifications
You must be signed in to change notification settings - Fork 74
Modify esp32 socket.write to reflect socket core module api #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to ease the transition please have a |
@ladyada added and tested with the current (pre-PR'd) version of |
"""Send some data to the socket""" | ||
_the_interface.socket_write(self._socknum, data) | ||
gc.collect() | ||
|
||
def write(self, data): | ||
"""Sends data to the socket.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a note this is deprecated, and will be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted!
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.9.2 from 1.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#71 from brentru/switch-read > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#70 from brentru/sock-send > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#68 from mscosti/get_time_err_ap Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.0.1 from 5.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#55 from jerryneedell/jerryn_adc > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#53 from jerryneedell/jerryn_pygamer Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 1.1.4 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#8 from brentru/switch-read > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#7 from brentru/sock-send Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.1.2 from v1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#9 from brentru/switch-read > Merge pull request adafruit/Adafruit_CircuitPython_Requests#8 from brentru/sock-send
Switching
socket.write
tosocket.send
to match the CircuitPython Socket API and the CPython Socket API.Related library PRs:
Tested on:
Adafruit CircuitPython 4.0.2 on 2019-06-27; Adafruit PyPortal with samd51j20
Tests ran:
esp32spi_simpletest.py
- ESP + Requestsesp32spi_aio_post.py
- WiFiManager + Requestsesp32spi_wsgiserver.py
- server + esp