raise AP specific error when trying to get_time while in AP mode #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
approved these changes
Aug 28, 2019
|
@mscosti Thanks for making these changes, merging in... |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 30, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.9.2 from 1.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#71 from brentru/switch-read > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#70 from brentru/sock-send > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#68 from mscosti/get_time_err_ap Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.0.1 from 5.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#55 from jerryneedell/jerryn_adc > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#53 from jerryneedell/jerryn_pygamer Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 1.1.4 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#8 from brentru/switch-read > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#7 from brentru/sock-send Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.1.2 from v1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#9 from brentru/switch-read > Merge pull request adafruit/Adafruit_CircuitPython_Requests#8 from brentru/sock-send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would have already been correctly raising an error when trying to get_time if we were in AP mode instead of connected to WiFi.
This change just adds a more targeted error message if we detect you are in AP mode and trying to get_time