Skip to content

Fix error from save_text = False #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2021
Merged

Fix error from save_text = False #160

merged 1 commit into from
Dec 24, 2021

Conversation

tekktrik
Copy link
Member

This PR should address Issue #157 but I don't have the hardware to test, just followed the code to figure out what was happening. Use of local variable text instead of self._text should fix the issue.

@tekktrik tekktrik mentioned this pull request Dec 21, 2021
Closed
@PaulskPt
Copy link

I applied the changes to bitmap_label.py. As far as I can see it works. No crash. See the annotated screenshot.

adafruit_display_text__bitmap_label py_mod_by_tekktrik

@tekktrik
Copy link
Member Author

Yahoo! That's great to hear!

FoamyGuy
FoamyGuy approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @tekktrik for the fix and @PaulskPt for trying it out.

@FoamyGuy FoamyGuy merged commit d507c98 into adafruit:main Dec 24, 2021
@tekktrik
Copy link
Member Author

My pleasure, thanks everyone for the help and support in addressing the issue!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 24, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@e796bc0)
fed4897 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.21.2 from 2.21.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#161 from tekktrik/doc/update-typing
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#160 from tekktrik/hotfix/fix-save-text
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.16.0 from 1.15.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#62 from s-light/widget_cartesian__update_line__bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tekktrik @PaulskPt @FoamyGuy