Skip to content

Widget cartesian update line bugfix #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 23, 2021

Conversation

s-light
Copy link
Contributor

@s-light s-light commented Dec 16, 2021

fixes #61
and fixes misalignment of graph to axis.
there was a factor missing..

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @s-light

@FoamyGuy FoamyGuy mentioned this pull request Dec 17, 2021
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @s-light. I have a few small requests but this is looking good to me for the most part.

Tested successfully on PyPortal 7.1.0-beta.3

@s-light
Copy link
Contributor Author

s-light commented Dec 21, 2021

@FoamyGuy i just questioned myself if it makes more sens to change the nameing to line_add() and lines_clear() or plot_add_line and plot_clear or graph_add_line and graph_clear
this way it feels a little bit better ordered....
what you are thinking?

@FoamyGuy
Copy link
Contributor

@s-light I do like the idea of adding "plot" to the names to make it distinct from the axis lines. How about add_plot_line() and clear_plot_lines()?

@s-light
Copy link
Contributor Author

s-light commented Dec 22, 2021

so you prefer the action first naming?
(i personally prefer object subobject action naming... this also help for simple autocomplete - all the function/attribut names start with the object name the belong to...)
i am fine with this. :-)

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-light I do prefer action first naming. However I do see the upside you mention about autocomplete. I may be spoiled a bit in that regards. I think PyCharm autocomplete is good about showing options even if I enter them out of order so if I start typing something like my_plane.line I will still get add_plot_line and clear_plot_lines in the list of possible completions even though they don't begin with "line" like I started typing.

@FoamyGuy FoamyGuy merged commit da84037 into adafruit:main Dec 23, 2021
@s-light s-light deleted the widget_cartesian__update_line__bugfix branch December 23, 2021 17:01
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 24, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.21.2 from 2.21.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#161 from tekktrik/doc/update-typing
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#160 from tekktrik/hotfix/fix-save-text
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.16.0 from 1.15.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#62 from s-light/widget_cartesian__update_line__bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cartesian how to use the update_line function?
2 participants