-
Notifications
You must be signed in to change notification settings - Fork 15
Widget cartesian update line bugfix #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget cartesian update line bugfix #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @s-light
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @s-light. I have a few small requests but this is looking good to me for the most part.
Tested successfully on PyPortal 7.1.0-beta.3
@FoamyGuy i just questioned myself if it makes more sens to change the nameing to |
@s-light I do like the idea of adding "plot" to the names to make it distinct from the axis lines. How about |
so you prefer the action first naming? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@s-light I do prefer action first naming. However I do see the upside you mention about autocomplete. I may be spoiled a bit in that regards. I think PyCharm autocomplete is good about showing options even if I enter them out of order so if I start typing something like my_plane.line
I will still get add_plot_line
and clear_plot_lines
in the list of possible completions even though they don't begin with "line" like I started typing.
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.21.2 from 2.21.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#161 from tekktrik/doc/update-typing > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#160 from tekktrik/hotfix/fix-save-text > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.16.0 from 1.15.2: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#62 from s-light/widget_cartesian__update_line__bugfix
fixes #61
and fixes misalignment of graph to axis.
there was a factor missing..