Skip to content

ButtonPacket did not work in CPython #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

ButtonPacket did not work in CPython #30

merged 1 commit into from
Mar 25, 2021

Conversation

dhalbert
Copy link
Contributor

ButtonPacket was trying to use a str in struct.pack(). This works in CircuitPython, but not CPython.

@dhalbert dhalbert requested a review from a team March 25, 2021 17:17
@dhalbert
Copy link
Contributor Author

Thanks @cs80 for finding this issue when using the library with CPython.

@dhalbert dhalbert force-pushed the buttonpacket-bytes branch from 9ee1539 to 234fd10 Compare March 25, 2021 17:24
tannewt
tannewt approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit b5b80e0 into adafruit:master Mar 25, 2021
@dhalbert dhalbert deleted the buttonpacket-bytes branch March 25, 2021 18:50
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 26, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a6c2669)
84badba 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#28 from lcongdon/fix-from_stream
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#29 from ehippy/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#30 from dhalbert/buttonpacket-bytes
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt