Skip to content

Fix failure in from_stream method #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

Fix failure in from_stream method #28

merged 1 commit into from
Mar 25, 2021

Conversation

lcongdon
Copy link
Contributor

@lcongdon lcongdon commented Feb 4, 2021

from_stream method of the Packet class fails when getting the packet_class from the _type_to_class dictionary because header is a bytearray and not hashable. This change makes header hashable and corrects the error.

dhalbert
dhalbert approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dhalbert dhalbert merged commit 9daa759 into adafruit:master Mar 25, 2021
@dhalbert dhalbert mentioned this pull request Mar 25, 2021
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 26, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a6c2669)
84badba 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#28 from lcongdon/fix-from_stream
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#29 from ehippy/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#30 from dhalbert/buttonpacket-bytes
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcongdon @dhalbert