feedback from pr61 #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
requested changes
Jul 11, 2023
|
The latest commit adopts the requested change. Take another look when you have a chance @tekktrik |
# Conflicts: # adafruit_bme680.py
|
I'm going to merge this based on the original 'looks good' other than the addressed change. We can always add or change things in the future if anything else comes up. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 9, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.7.2 from 3.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_BME680#62 from FoamyGuy/pr61_followup Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.7.4 from 5.7.3: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#108 from adafruit/update_simpletest_esp32s2 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles all items noted in the comments in #61.
@tekktrik you mentioned in the other thread wanting to take another look after those things were changed. Once you have a chance to do that let me know and I can add any further changes to this branch.
The one change in this that wasn't mentioned was the removal of:
I found that pylint is passing even without that so I removed it.