-
Notifications
You must be signed in to change notification settings - Fork 31
Update for settings.toml (CPY8) and SSL. #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested on Adafruit Feather ESP32-S2 Reverse TFT with CPY 8.2.4
69005e1
to
46d93c2
Compare
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
Just to add the root certs in CPY 8.2.4 still fail with API.github.com but Dan will cut a new release with updated root certs this week (8.2.5) |
I will test this, but probably not until tomorrow (sorry!). Tyeth was able to help get me working code to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I tested it successfully on a Feather ESP32-S2 TFT with CircuitPython 8.2.6
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.7.2 from 3.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_BME680#62 from FoamyGuy/pr61_followup Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.7.4 from 5.7.3: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#108 from adafruit/update_simpletest_esp32s2 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
How were you able to get io.connect() working? |
Looking at my code, it looks like I used normal MQTT and not |
Tested on Adafruit Feather ESP32-S2 Reverse TFT with CPY 8.2.4.
Paul Cutler raised an issue in discord about using SSL and miniMQTT with the IO library, and I realised I hadn't retested with SSL in circuitpython for a while especially since Root cert updates. The version Paul was using was 8.2.2 which has an SSL issue connecting to api.github.com so advised to update to latest CPY of 8.2.4 to get up to date root certs.
This brings the demo for the esp32s2 up to scratch, working with secrets.py or settings.toml, and optionally connecting to wifi. The port is also changed and is_ssl=True to enable SSL.