Skip to content

Update for settings.toml (CPY8) and SSL. #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Sep 2, 2023

Tested on Adafruit Feather ESP32-S2 Reverse TFT with CPY 8.2.4.

Paul Cutler raised an issue in discord about using SSL and miniMQTT with the IO library, and I realised I hadn't retested with SSL in circuitpython for a while especially since Root cert updates. The version Paul was using was 8.2.2 which has an SSL issue connecting to api.github.com so advised to update to latest CPY of 8.2.4 to get up to date root certs.

This brings the demo for the esp32s2 up to scratch, working with secrets.py or settings.toml, and optionally connecting to wifi. The port is also changed and is_ssl=True to enable SSL.

Tested on Adafruit Feather ESP32-S2 Reverse TFT with CPY 8.2.4
@tyeth tyeth force-pushed the update_simpletest_esp32s2 branch from 69005e1 to 46d93c2 Compare September 2, 2023 19:55
@tyeth tyeth requested a review from brentru September 2, 2023 19:55
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

@tyeth
Copy link
Contributor Author

tyeth commented Sep 2, 2023

@brentru This relates to #99

@brentru
Copy link
Member

brentru commented Sep 5, 2023

@prcutler Could you test if this fixes #107?

@tyeth
Copy link
Contributor Author

tyeth commented Sep 5, 2023

Just to add the root certs in CPY 8.2.4 still fail with API.github.com but Dan will cut a new release with updated root certs this week (8.2.5)
There's an open issue in the Adafruit nina-fw repo

@prcutler
Copy link

prcutler commented Sep 5, 2023

I will test this, but probably not until tomorrow (sorry!). Tyeth was able to help get me working code to use io.connect() but I will try the simpletest out. Thanks for the quick responses!

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I tested it successfully on a Feather ESP32-S2 TFT with CircuitPython 8.2.6

@FoamyGuy FoamyGuy merged commit eec28fe into main Oct 8, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 9, 2023
@luke-edward
Copy link

prcutler

How were you able to get io.connect() working?

@prcutler
Copy link

Looking at my code, it looks like I used normal MQTT and not io.connect. It looks like the original issue was due to a root certificate problem, it should work on 8.2.9 or later.

@dhalbert dhalbert deleted the update_simpletest_esp32s2 branch January 19, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants