Skip to content

Updated to use topic specific subscriptions #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 10, 2020
Merged

Updated to use topic specific subscriptions #18

merged 5 commits into from
Jun 10, 2020

Conversation

jimbobbennett
Copy link
Collaborator

@jimbobbennett jimbobbennett commented Jun 8, 2020 •
edited
Loading

Based off adafruit/Adafruit_CircuitPython_MiniMQTT#38 - this change uses the new topic specific subscriptions. This should not be merged till the miniMQTT PR is merged and released.

This is a fix for #15

Jim Bennett added 3 commits June 7, 2020 15:12
merging
5dbbfa7 
Revert "merging"

This reverts commit 4f3aea6b2cfaa98be31d82e5076fe3df29d198f7.

Revert "Revert "merging""

This reverts commit a250e00d6964442592fad5fbeb7f31ddb339daf7.

Delete mpy.sh
Added initial support for topic-based subscriptions
3eed9fc
Removing on_message as it's no longer needed
d7d4a66
@jimbobbennett jimbobbennett requested a review from brentru June 8, 2020 18:55
@jimbobbennett jimbobbennett mentioned this pull request Jun 8, 2020
Merged
@jimbobbennett jimbobbennett linked an issue Jun 8, 2020 that may be closed by this pull request
Update to use the new topic-specific callbacks #15
Closed
@jimbobbennett jimbobbennett marked this pull request as ready for review June 9, 2020 22:51
brentru
brentru approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice implementation of the topic-specific subscriptions.

@brentru brentru merged commit 6735960 into adafruit:master Jun 10, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 11, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b025932)
fcd9964 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.3.0 from 2.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#18 from jimbobbennett/topic_subscribe
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#19 from jimbobbennett/fix_example_names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to use the new topic-specific callbacks
2 participants
@jimbobbennett @brentru