Add feed callback mechanism #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Sep 28, 2020
tannewt
reviewed
Sep 28, 2020
|
|
||
| """ | ||
| self._client.remove_topic_callback("{0}/feeds/{1}".format(self._user, feed_key)) | ||
|
|
||
| def loop(self): | ||
| """Manually process messages from Adafruit IO. | ||
| Call this method to check incoming subscription messages. |
There was a problem hiding this comment.
Please add a sentence here about how it will call the event handlers depending on the type of message.
There was a problem hiding this comment.
addressing this here: #47
tannewt
reviewed
Sep 28, 2020
| if self._logger: | ||
| self._client._logger.debug("Client called on_unsubscribe") | ||
| if self.on_unsubscribe is not None: | ||
| self.on_unsubscribe(self, user_data, topic, pid) | ||
|
|
||
| def add_feed_callback(self, feed_key, callback_method): | ||
| """Executes callback_method whenever a message is | ||
| received on feed_key. |
There was a problem hiding this comment.
Please mention here that the method is called by loop.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 29, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.3.4 from 1.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#22 from caternuson/iss12 Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 4.2.0 from 4.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#46 from brentru/add-callback-feed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #45
Tested on
Adafruit CircuitPython 5.3.1 on 2020-07-13; Adafruit PyPortal with samd51j20Test is the example modified to include
remove_callbackExpected behavior - should not fire a second time since it's removed
Behavior: