Skip to content

Expose feed callbacks via MiniMQTT topic callbacks #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brentru opened this issue Sep 28, 2020 · 1 comment
Closed

Expose feed callbacks via MiniMQTT topic callbacks #45

brentru opened this issue Sep 28, 2020 · 1 comment
Assignees
@brentru
Labels
enhancement New feature or request

Comments

@brentru
Copy link
Member

brentru commented Sep 28, 2020

MiniMQTT is able to execute a method if a new message is received on a topic. To keep in-line with the naming convention of Adafruit IO, this method should be named add_feed_callback instead of the MiniMQTT's standard add_topic_callback

Example: https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/blob/master/examples/minimqtt_pub_sub_blocking_topic_callbacks.py
@brentru brentru added the enhancement New feature or request label Sep 28, 2020
@brentru brentru self-assigned this Sep 28, 2020
@brentru
Copy link
Member Author

brentru commented Sep 28, 2020

also, add remove_feed_callback(feed_name)

@brentru brentru mentioned this issue Sep 28, 2020
Merged
@brentru brentru closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentru brentru

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brentru