Skip to content

Correct Missing Type Annotations #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2023
Merged

Correct Missing Type Annotations #8

merged 2 commits into from
Jan 7, 2023

Conversation

tcfranks
Copy link
Contributor

resolves #3
submitted for review / comment

FoamyGuy
FoamyGuy requested changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @tcfranks!

I have a question and few suggested changes in places where some arguments didn't get types yet.

@tcfranks
Copy link
Contributor Author

tcfranks commented Jan 4, 2023

submitted with requested changes but forgot to retitle the commit

FoamyGuy
FoamyGuy approved these changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks again!

@FoamyGuy FoamyGuy merged commit 94f8b9e into adafruit:main Jan 7, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 8, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@85a9103)
21ab1b0 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AW9523 to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_AW9523#8 from tcfranks/main
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tcfranks @FoamyGuy