Skip to content

Replacing named tuple #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2021
Merged

Replacing named tuple #17

merged 2 commits into from
May 7, 2021

Conversation

jposada202020
Copy link
Contributor

@jposada202020 jposada202020 commented May 7, 2021 •
edited
Loading

This solves #13 . Thanks

Tests

Before

Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit Feather RP2040 with rp2040
>>> from adafruit_as7341 import SMUX_OUT, SMUX_IN
>>> print(SMUX_IN.NC_DARK, SMUX_OUT.ADC2)
18 3
>>>

After

Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit Feather RP2040 with rp2040
>>> from adafruit_as7341 import SMUX_OUT, SMUX_IN
>>> print(SMUX_IN.NC_DARK, SMUX_OUT.ADC2)
18 3
>>>

Also test with the examples in the library on

Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit Feather RP2040 with rp2040

@jposada202020 jposada202020 linked an issue May 7, 2021 that may be closed by this pull request
namedtuple usage doesn't work on all boards. #13
Closed
@jposada202020 jposada202020 requested a review from a team May 7, 2021 21:02
@jposada202020 jposada202020 merged commit c529ef2 into adafruit:main May 7, 2021
@jposada202020 jposada202020 deleted the replacing_named_tuple branch May 7, 2021 23:10
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 11, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
0a4fcd5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#17 from jposada202020/replacing_named_tuple

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#17 from jposada202020/adding_waitingtime_as_option

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#13 from jposada202020/adding_readme_note

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.9 from 2.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#30 from jposada202020/returning_correct_units_gyro

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPU6050 to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPU6050#17 from jposada202020/correcting_returning_units_gyro

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.10.0 from 1.9.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#36 from xorbit/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.3.0 from 5.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#70 from rodrigoargumedo/create-multiple-records

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#78 from flavio-fernandes/fix.issue.77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

namedtuple usage doesn't work on all boards.
2 participants
@jposada202020 @ladyada