feat: Add circular queue data structure implementation #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcnovaes
changed the title
appgurueu
reviewed
Oct 25, 2022
appgurueu
reviewed
Oct 25, 2022
appgurueu
reviewed
Oct 25, 2022
appgurueu
reviewed
Oct 25, 2022
Data-Structures/Queue.ts
Outdated
| * @function .length - returns the size of the qeuue | ||
| * @function .isEmpty - returns if the queue is empty | ||
| */ | ||
| /* queue data-structure. It's work is based on the LIFO method (last-IN-first-OUT). |
There was a problem hiding this comment.
Please clean up your comments here
appgurueu
reviewed
Oct 25, 2022
- Making suggested changes
|
I choosed to use a circular array implementation of the queue, is this ok? |
appgurueu
requested changes
Oct 27, 2022
|
I made the suggested changes, I think that an queue interface it makes more sense when other implementation of queue is added |
appgurueu
requested changes
Oct 27, 2022
appgurueu
changed the title
appgurueu
reviewed
Oct 29, 2022
| @@ -2,7 +2,13 @@ | |||
| * @class CircularQueue | |||
| * @description Circular implementation of a queue | |||
| */ | |||
| export class CircularQueue<T> { | |||
| export interface Queue<T> { | |||
There was a problem hiding this comment.
No. That way you still get rid of the non-circular Queue implementation. I want there to be two Queue classes, one circular and the other one not circular. They may both implement a common interface.
|
@appgurueu This PR can be closed. Implemented in #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of a queue data structure class