Skip to content

feat(structure): implements circular queue #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

zFl4wless
Copy link
Contributor

This PR implements a circular queue, which has already been started but never finished in #70
Because we now have a general interface for the Queue, I decided to create a new branch with the implementation and create the Circular Queue with the already existing interface instead of fighting with potential merge conflicts.

Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether CircularQueue should implement the Queue interface. Yes, it provides the same methods with the same signatures. But the semantics are different. Interfaces are for different classes implementing the same semantics.

@zFl4wless zFl4wless requested review from appgurueu and removed request for raklaptudirm March 17, 2023 21:21
@raklaptudirm raklaptudirm merged commit 2ac83c8 into TheAlgorithms:master Mar 22, 2023
@zFl4wless zFl4wless deleted the structure/circular-queue branch March 22, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants