Added a new file proof_of_work.py which is used in most blockchains #9061
Conversation
About issue #9051, will continue to add few more algorithms related to blockchian.
for more information, see https://pre-commit.ci
|
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| difficulty = 4 | ||
|
|
||
|
|
||
| def generate_random_string(length): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file blockchain/proof_of_work.py, please provide doctest for the function generate_random_string
Please provide return type hint for the function: generate_random_string. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: length
| return "".join(random.choice(characters) for _ in range(length)) | ||
|
|
||
|
|
||
| def proof_of_work(difficulty): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file blockchain/proof_of_work.py, please provide doctest for the function proof_of_work
Please provide return type hint for the function: proof_of_work. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: difficulty
About issue #9051, will continue to add few more algorithms related to blockchian.
Describe your change: