Skip to content

blockchain section doesn't contain blockchain-related algorithms #9051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ar406 opened this issue Sep 10, 2023 · 2 comments · Fixed by #10084
Closed

blockchain section doesn't contain blockchain-related algorithms #9051

ar406 opened this issue Sep 10, 2023 · 2 comments · Fixed by #10084
Labels
awaiting triage Awaiting triage from a maintainer

Comments

@ar406
Copy link

ar406 commented Sep 10, 2023

What would you like to share?

The blockchain section contains a README which starts talking about blockchains, DLTs and cryptography, as expected, but then includes links to the Chinese Remainder Theorem and modular division.

While certainly interesting topics, they are not strictly related to blockchains.

The Chinese Remainder Theorem is used in many RSA implementations, but RSA is not used in blockchains like Bitcoin and Ethereum.

Hashes such as SHA256 are by far more related to blockchains, but they are implemented in the hash/ directory.

I believe the blockchain section, in its current version, is confusing.

Some possible solutions:

  • amend the documentation
  • move CRTs, modular division to a new directory (maybe number theory? Linear algebra already exists and looks like a nice precedent)
  • rename the blockchain directory

Additional information

No response

@ar406 ar406 added the awaiting triage Awaiting triage from a maintainer label Sep 10, 2023
@tianyizheng02
Copy link
Contributor

I completely agree. I personally don't think that any of the algorithms in the blockchain directory are directly related to blockchains, and they'd belong better under another directory such as maths. I'd be in favor of removing the blockchain directory entirely and relocating the algorithms. @cclauss, thoughts?

@cclauss
Copy link
Member

cclauss commented Sep 16, 2023

amend the documentation

I would really like to continue having a blockchain directory but I am OK if we remove non-blockchain algorithms and text. Let's have a place that helps visitors learn about blockchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment