Skip to content

Enhancement/issue 8427 #8810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Enhancement/issue 8427 #8810

wants to merge 11 commits into from

Conversation

elsayed2440
Copy link

Describe your change:

Describe your change:

Impelementation of 2 algorithms from the ones mentioned in the issue #8427 , namely the sliding window algorithm and Kadane's algorithm.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@elsayed2440 elsayed2440 requested a review from cclauss as a code owner June 7, 2023 22:56
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jun 7, 2023
@elsayed2440 elsayed2440 closed this Jun 7, 2023
@cclauss
Copy link
Member

cclauss commented Jun 8, 2023

Please stop opening and closing the same pull request as it pollutes my inbox. Instead make multiple commits to the same pull request until you are satisfied with the result.

Please do not put the issue number in the title because it is not self-documenting and it is not clickable. If #8427 is in the body of the commit message the visitors can click on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants