Skip to content

Add algorithms like Sliding Window, Region Proposal Networks, or Kadane's Algorithm etc. #8427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harshita130602 opened this issue Mar 21, 2023 · 13 comments
Labels
enhancement This PR modified some existing files

Comments

@harshita130602
Copy link

Feature description

While going through the repository, I could not find such algorithms. It would be a good idea to add them to the repository.

@harshita130602 harshita130602 added the enhancement This PR modified some existing files label Mar 21, 2023
@rohan472000
Copy link
Contributor

Feature description

While going through the repository, I could not find such algorithms. It would be a good idea to add them to the repository.

can i take this issue?

@cclauss
Copy link
Member

cclauss commented Mar 27, 2023

We do not assign issues. We review pull requests.

@rohan472000
Copy link
Contributor

I'm getting below error while creating pull request.....why?

remote: Permission to TheAlgorithms/Python.git denied to rohan472000.
fatal: unable to access 'https://github.com/TheAlgorithms/Python.git/': The requested URL returned error: 403

@cclauss
Copy link
Member

cclauss commented Mar 28, 2023

Remove the slash on the end and try again.

What command are you running when you get this error? What is the full error message?

@rohan472000
Copy link
Contributor

rohan472000 commented Mar 28, 2023

Remove the slash on the end and try again.

What command are you running when you get this error? What is the full error message?

git push origin rohan

above command I'm running

below is the full error :

PS C:\pycharm\codes\Python-pull> git add .
PS C:\pycharm\codes\Python-pull> git commit -m "added kadane_algo and sliding_window directory with codes"
[rohan f5912e1] added kadane_algo and sliding_window directory with codes
1 file changed, 1 insertion(+), 1 deletion(-)
PS C:\pycharm\codes\Python-pull> git push origin rohan
remote: Permission to TheAlgorithms/Python.git denied to rohan472000.
fatal: unable to access 'https://github.com/TheAlgorithms/Python.git/': The requested URL returned error: 403

@cclauss
Copy link
Member

cclauss commented Mar 28, 2023

What do you see when you type these two commands
% git branch
% git remote -v

@rohan472000
Copy link
Contributor

rohan472000 commented Mar 28, 2023

this i can see after above command

PS C:\pycharm\codes\Python-pull> git branch
master

  • rohan

PS C:\pycharm\codes\Python-pull> git remote -v
origin https://github.com/TheAlgorithms/Python.git (fetch)
origin https://github.com/TheAlgorithms/Python.git (push)

@cclauss
Copy link
Member

cclauss commented Mar 28, 2023

This is how I do it... My fork is origin and the main public repo is upstream.
% git remote -v

origin	https://github.com/cclauss/Python (fetch)
origin	https://github.com/cclauss/Python (push)
upstream	https://github.com/TheAlgorithms/Python (fetch)
upstream	https://github.com/TheAlgorithms/Python (push)

Like: https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet
Or: https://devguide.python.org/getting-started/git-boot-camp

@rohan472000
Copy link
Contributor

PS C:\pycharm\codes\Python-pull> git pull upstream master
fatal: 'upstream' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@rohan472000
Copy link
Contributor

@cclauss my PR is getting closed everytime by bot though i followed every necessary step for contributing, can you suggest me doc or channel where i can get a demo how to get our PR merged with ticking all checks.

@cclauss
Copy link
Member

cclauss commented Mar 28, 2023

Check at least one of the checkboxes in the commit message.

@rohan472000
Copy link
Contributor

Is there any algorithm left? If yes then kindly tell, I would try to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

No branches or pull requests

3 participants