Skip to content

Delete euclidean_gcd.py #8078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Delete euclidean_gcd.py #8078

wants to merge 1 commit into from

Conversation

HighnessAtharva
Copy link

@HighnessAtharva HighnessAtharva commented Jan 5, 2023 •
edited
Loading

workerB
Take care of issue #8063 by removing duplicate problem solution
Fixes: #8063

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@HighnessAtharva
Delete euclidean_gcd.py
a9ed4bd 
Take care of issue #8063 by removing duplicate problem solution
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Jan 5, 2023
@HighnessAtharva
Copy link
Author

@tianyizheng02 can you please review this? It addresses your issue.

@tianyizheng02
Copy link
Contributor

Looks good, but it'll be up to the repo owners/maintainers to decide whether it's OK to merge

@tianyizheng02
Copy link
Contributor

Also you need to put the Fixes: #8063 in your PR comment rather than the PR title for GitHub to automatically link the PR to the issue

@HighnessAtharva HighnessAtharva changed the title Fixes: #8063 Delete euclidean_gcd.py Jan 5, 2023
@HighnessAtharva
Copy link
Author

Also you need to put the Fixes: #8063 in your PR comment rather than the PR title for GitHub to automatically link the PR to the issue

Done

@tianyizheng02
Copy link
Contributor

Oh, not in a code block, just in normal text:

Fixes: #8063

You'll see it under the Development section on the right-hand side of the page if it worked

screenshot

@HighnessAtharva HighnessAtharva closed this by deleting the head repository Jan 5, 2023
@cclauss cclauss mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate GCD implementation
2 participants
@HighnessAtharva @tianyizheng02