Skip to content

Remove duplicate GCD implementation #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianyizheng02 opened this issue Dec 30, 2022 · 6 comments · Fixed by #9108
Closed

Remove duplicate GCD implementation #8063

tianyizheng02 opened this issue Dec 30, 2022 · 6 comments · Fixed by #9108
Labels
enhancement This PR modified some existing files

Comments

@tianyizheng02
Copy link
Contributor

Feature description

greatest_common_divisor.py and euclidean_gcd.py both have basically the same two implementations of the Euclidean algorithm for calculating the GCD of 2 numbers. Thus, one of them should probably be removed as a duplicate.

@tianyizheng02 tianyizheng02 added the enhancement This PR modified some existing files label Dec 30, 2022
@itsvinayak
Copy link
Member

@cclauss which one we should keep

@ArhamaQ
Copy link

ArhamaQ commented Sep 25, 2023

Hey, I am Arhama . I am a beginner in open source contribution. I think I Can work on this issue. can you assign me this work.

@cclauss
Copy link
Member

cclauss commented Sep 25, 2023

can you assign me this work.

https://github.com/TheAlgorithms/Python/pull/8871/files

My preference would be to delete the file whose name uses the gcd acronym and keep the file whose name is self-documenting (as #8078 attempted to do).

@HimanshuMahto
Copy link

Hey, is this still an issue to work on if yes can I do it

@tianyizheng02
Copy link
Contributor Author

@HimanshuMahto Read the contributing guidelines.

If you are interested in resolving an open issue, simply make a pull request with your proposed fix. We do not assign issues in this repo so please do not ask for permission to work on an issue.

@aryan1165
Copy link
Contributor

aryan1165 commented Sep 27, 2023

Hey, I have created a PR #9108 which addresses this issue. Please review it. Thanks!

@cclauss cclauss mentioned this issue Sep 27, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants