-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Remove duplicate GCD implementation #8063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@cclauss which one we should keep |
Hey, I am Arhama . I am a beginner in open source contribution. I think I Can work on this issue. can you assign me this work. |
https://github.com/TheAlgorithms/Python/pull/8871/files My preference would be to delete the file whose name uses the gcd acronym and keep the file whose name is self-documenting (as #8078 attempted to do). |
Hey, is this still an issue to work on if yes can I do it |
@HimanshuMahto Read the contributing guidelines.
|
Hey, I have created a PR #9108 which addresses this issue. Please review it. Thanks! |
Feature description
greatest_common_divisor.py
andeuclidean_gcd.py
both have basically the same two implementations of the Euclidean algorithm for calculating the GCD of 2 numbers. Thus, one of them should probably be removed as a duplicate.The text was updated successfully, but these errors were encountered: