Skip to content

Add Ideal Gas Law for physics #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 30, 2022
Merged

Add Ideal Gas Law for physics #6503

merged 8 commits into from
Oct 30, 2022

Conversation

kavienanj
Copy link
Contributor

@kavienanj kavienanj commented Oct 2, 2022 •
edited
Loading

Ideal Gas Law consists of 2 functions with return computed values for pressure and volume of a gas system according to given input values.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 2, 2022
CaedenPH
CaedenPH approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

kavienanj and others added 2 commits October 2, 2022 17:42
@kavienanj @CaedenPH
Update physics/ideal_gas_law.py
63b2f12 
Suggestion #1

Co-authored-by: Caeden <[email protected]>
@kavienanj @CaedenPH
Update physics/ideal_gas_law.py
6b9a10d 
Suggestion #2

Co-authored-by: Caeden <[email protected]>
@kavienanj
Copy link
Contributor Author

Added the suggestions! Please accept these changes

@kavienanj kavienanj requested a review from CaedenPH October 2, 2022 12:16
ZeroDayOwl
ZeroDayOwl suggested changes Oct 16, 2022
View reviewed changes
CaedenPH
CaedenPH reviewed Oct 16, 2022
View reviewed changes
CaedenPH
CaedenPH reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last things from me

@CaedenPH
Copy link
Contributor

@cclauss I think this is worthy of review - Perhaps committing my changes might be good, however the pr in general looks good

@cclauss @CaedenPH
Apply suggestions from code review
2bb3442 
Co-authored-by: Caeden Perelli-Harris <[email protected]>
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@cclauss cclauss merged commit c0b0b12 into TheAlgorithms:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@ZeroDayOwl ZeroDayOwl ZeroDayOwl requested changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kavienanj @CaedenPH @cclauss @ZeroDayOwl