Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[mypy] Fix type annotations for maths directory #5782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mypy] Fix type annotations for maths directory #5782
Changes from all commits
e34dd4d
cea397e
7173166
b5440ec
1ce55e7
95e41dd
4f00c09
99a0cf5
e9c81ab
d2a04cf
567210b
6b07a1f
175b785
9902c88
e52a293
e98c58e
83af001
dc86c78
33b0977
9bbace1
bbfcc6e
dbc81e9
289c029
9f7c657
d384199
db95b64
ae56fe9
b610e7f
882a12c
d645da0
d112ce4
dd1ff0a
c416d74
a9d9c1e
85b0ba8
5078821
6bf7b4c
8da52be
db01780
2e5cafb
7508c25
e8cb833
bdb576d
a362ea5
f4597b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a cooler test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make all strings here instead of floats, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation is tolerant of both. We should not lose that flexibility. Our type hint says that we expect float but our implementation is flexible to do the right thing if someone hands us something that is not a float but is still reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://pydantic-docs.helpmanual.io does a nice job of this.