Skip to content

[mypy] Fix type annotations for maths directory #5782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Nov 7, 2021
Merged

[mypy] Fix type annotations for maths directory #5782

merged 45 commits into from
Nov 7, 2021

Conversation

Rohanrbharadwaj
Copy link
Contributor

@Rohanrbharadwaj Rohanrbharadwaj commented Nov 6, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Nov 6, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 6, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 6, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 6, 2021
@Rohanrbharadwaj Rohanrbharadwaj changed the title [mypy] Fix annotations in maths/series/p_series.py [mypy] Fix annotations in maths/series/p_series.py and maths/proth_number.py Nov 6, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 6, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 6, 2021
@Rohanrbharadwaj Rohanrbharadwaj changed the title [mypy] Fix annotations in maths/series/p_series.py and maths/proth_number.py [mypy] Fix annotations for 3 files in the maths directory Nov 6, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 6, 2021
@Rohanrbharadwaj Rohanrbharadwaj changed the title [mypy] Fix annotations for 3 files in the maths directory [mypy] Fix annotations for maths directory Nov 6, 2021
@Rohanrbharadwaj Rohanrbharadwaj changed the title [mypy] Fix annotations for maths directory [mypy] Fix type annotations for maths directory Nov 6, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 7, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 7, 2021
cclauss
cclauss reviewed Nov 7, 2021
View reviewed changes
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 7, 2021
cclauss
cclauss reviewed Nov 7, 2021
View reviewed changes
cclauss
cclauss reviewed Nov 7, 2021
View reviewed changes
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 7, 2021
@Rohanrbharadwaj
Copy link
Contributor Author

data_structures/stacks/next_greater_element.py can be removed from the excluded ones in mypy.ini, since it was fixed in #5763.

cclauss
cclauss approved these changes Nov 7, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME!!!

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 7, 2021
@cclauss cclauss merged commit a984652 into TheAlgorithms:master Nov 7, 2021
@Rohanrbharadwaj Rohanrbharadwaj deleted the patch-3 branch November 8, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rohanrbharadwaj @cclauss