Skip to content

[mypy]Correction of all errors in the sorts directory #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 23, 2021
Merged

[mypy]Correction of all errors in the sorts directory #4224

merged 5 commits into from
Feb 23, 2021

Conversation

MatthewG25
Copy link
Contributor

@MatthewG25 MatthewG25 commented Feb 22, 2021 •
edited
Loading

Describe your change:

Completion of all mypy errors apart from a stub error. See #4222 for more detail. The errors were four type annotations, and the last was a return statement error found in the cocktail_shaker_sort algorithm which was fixed.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 22, 2021
@l3str4nge l3str4nge merged commit a4726ca into TheAlgorithms:master Feb 23, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Feb 23, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@MatthewG25 @peRFectBeliever
[mypy]Correction of all errors in the sorts directory (TheAlgorithms#…
ed836a1 
…4224)

* [mypy] Add/fix type annotations for recursive_insertion_sort(TheAlgorithms#4085)

* [mypy] Add/fix type annotations for bucket_sort(TheAlgorithms#4085)

* [mypy] Reworked code for cocktail_shaker_sort so that missing return statement error is resolved(TheAlgorithms#4085)

* [mypy] Add/fix type annotations for patience_sort(TheAlgorithms#4085)

* [mypy] Add/fix type annotations for radix_sort(TheAlgorithms#4085)

Co-authored-by: goodm2 <4qjpngu8mem8cz>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@MatthewG25
[mypy]Correction of all errors in the sorts directory (TheAlgorithms#…
ec416c4 
…4224)

* [mypy] Add/fix type annotations for recursive_insertion_sort(TheAlgorithms#4085)

* [mypy] Add/fix type annotations for bucket_sort(TheAlgorithms#4085)

* [mypy] Reworked code for cocktail_shaker_sort so that missing return statement error is resolved(TheAlgorithms#4085)

* [mypy] Add/fix type annotations for patience_sort(TheAlgorithms#4085)

* [mypy] Add/fix type annotations for radix_sort(TheAlgorithms#4085)

Co-authored-by: goodm2 <4qjpngu8mem8cz>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@MatthewG25 @shermanhui
[mypy]Correction of all errors in the sorts directory (TheAlgorithms#…
8d76c78 
…4224)

* [mypy] Add/fix type annotations for recursive_insertion_sort(TheAlgorithms#4085)

* [mypy] Add/fix type annotations for bucket_sort(TheAlgorithms#4085)

* [mypy] Reworked code for cocktail_shaker_sort so that missing return statement error is resolved(TheAlgorithms#4085)

* [mypy] Add/fix type annotations for patience_sort(TheAlgorithms#4085)

* [mypy] Add/fix type annotations for radix_sort(TheAlgorithms#4085)

Co-authored-by: goodm2 <4qjpngu8mem8cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewG25 @l3str4nge