Skip to content

[mypy] Packages that are not recognised #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatthewG25 opened this issue Feb 22, 2021 · 1 comment
Closed

[mypy] Packages that are not recognised #4222

MatthewG25 opened this issue Feb 22, 2021 · 1 comment

Comments

@MatthewG25
Copy link
Contributor

When working on the sorting algorithms for issue #4085, there was one issue that I could not fix so I am raising it here. The issue is that certain packages are not recognised by mypy and can't check for errors as there is no PEP 561 complaint stub package for the installed package. From the mypy errors for the whole repository, the packages that are recognised but dont have stubs are pandas, qiskit, numpy, sklearn, matprolib, statsmodels, skfuzzy, cv2, PIL, mpmath, scipy, bs4, fake_useragent, lxml. For pytest and django it doesnt find any implementation or stubs for these packages. These errors according to mypy docs can be fixed by updating the packages, making our own PEP 561 compliant stub packages to work with or to replace the packages with ones with PEP 561 complaint packages. As only a contributor and with no experience with PEP 561 complaint stub packages and how they work, I didnt know how the other contributors or the owners of this repo want to do with this. Hopefully this will help discussion on what to do now with this information

@cclauss
Copy link
Member

cclauss commented Mar 19, 2021

Run mypy --ignore-missing-imports as is done in #4274

@cclauss cclauss closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants