Skip to content

add count_number_of_one_bits.py #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2021
Merged

add count_number_of_one_bits.py #4195

merged 2 commits into from
Feb 12, 2021

Conversation

ayushbisht2001
Copy link
Contributor

Describe your change:

I have added an algorithm which counts the number of one (on bits) bits in a given positive integer.

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Feb 10, 2021
ruppysuppy
ruppysuppy suggested changes Feb 11, 2021
View reviewed changes
@ghost ghost added awaiting changes A maintainer has requested changes to this PR awaiting reviews This PR is ready to be reviewed and removed awaiting reviews This PR is ready to be reviewed awaiting changes A maintainer has requested changes to this PR labels Feb 11, 2021
ayushbisht2001
ayushbisht2001 commented Feb 11, 2021
View reviewed changes
Copy link
Contributor Author

@ayushbisht2001 ayushbisht2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@ghost ghost added the tests are failing Do not merge until tests pass label Feb 11, 2021
@ayushbisht2001
Copy link
Contributor Author

@ruppysuppy , some of the checks are failing because of the changes. Will you please review my PR.

@ruppysuppy
Copy link
Member

The check are failing because of wrong format, presumably due to extra space and wrong doctest please correct them, using flake8 and recheck the doctests

@ghost ghost removed the tests are failing Do not merge until tests pass label Feb 11, 2021
@ayushbisht2001
Copy link
Contributor Author

@ruppysuppy , now it's good to go??

@ruppysuppy ruppysuppy merged commit d3ac521 into TheAlgorithms:master Feb 12, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Feb 12, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@ayushbisht2001 @peRFectBeliever
add count_number_of_one_bits.py (TheAlgorithms#4195)
2b09c4b 
* count-bits

* update
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@ayushbisht2001
add count_number_of_one_bits.py (TheAlgorithms#4195)
8b54695 
* count-bits

* update
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@ayushbisht2001 @shermanhui
add count_number_of_one_bits.py (TheAlgorithms#4195)
620c848 
* count-bits

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruppysuppy ruppysuppy ruppysuppy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushbisht2001 @ruppysuppy