Fixes: #3163 - Add new solution for problem 234 #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyftar
force-pushed
the
problem-234-fix
branch
from
9a40fa1 to
8f9d8ea
Compare
dhruvmanila
requested changes
Oct 11, 2020
dhruvmanila
added
the
awaiting changes
Hyftar
force-pushed
the
problem-234-fix
branch
from
8657f0e to
53ff5d8
Compare
dhruvmanila
approved these changes
Oct 11, 2020
gurukiran07
reviewed
Oct 11, 2020
| is_prime[2] = True | ||
|
|
||
| for i in range(3, int(n ** 0.5 + 1), 2): | ||
| index = i * 2 |
There was a problem hiding this comment.
In L39 index = i*i is one optimization here.
There was a problem hiding this comment.
While you are most likely right:
- The sieves of Eratosthenes is not my algorithm;
- Optimizing the sieves of Eratosthenes is out of the scope of my PR;
- The Pull Request is already merged.
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…rithms#3177) * Fixes: TheAlgorithms#3163 - Add new solution for problem 234 * Apply review suggestions
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
…rithms#3177) * Fixes: TheAlgorithms#3163 - Add new solution for problem 234 * Apply review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes the Project Euler problem 234 by implementing a new working solution that doesn't use any
input()calls.This PR closes #3163
Checklist:
Fixes: #{$ISSUE_NO}.