Skip to content

Hacktoberfest: Add solution to problem 74 #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 1, 2020
Merged

Hacktoberfest: Add solution to problem 74 #3110

merged 6 commits into from
Nov 1, 2020

Conversation

GGn0
Copy link
Contributor

@GGn0 GGn0 commented Oct 9, 2020 •
edited
Loading

Describe your change:

Add a solution to project Euler problem 74

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

#2695

@GGn0 GGn0 marked this pull request as ready for review October 9, 2020 10:44
@GGn0 GGn0 mentioned this pull request Oct 25, 2020
Closed
2 tasks
poyea
poyea reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the dedicated README for project_euler. In particular, the directory you need to put the algorithm in and some function signatures.

https://github.com/TheAlgorithms/Python/blob/master/project_euler/README.md

@GGn0 GGn0 marked this pull request as draft October 26, 2020 10:24
@GGn0 GGn0 marked this pull request as ready for review October 26, 2020 12:20
@GGn0 GGn0 requested a review from poyea October 26, 2020 12:22
@poyea
Copy link
Member

poyea commented Nov 1, 2020

Thank you for your pull request!🤩

@poyea poyea merged commit d8f573c into TheAlgorithms:master Nov 1, 2020
@GGn0 GGn0 deleted the project_euler_problem_74 branch November 1, 2020 14:31
@dhruvmanila
Copy link
Member

This solution needed optimization as its taking 2 minutes to run. Now our tests will take 2x longer to finish lol.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@GGn0 @stokhos
Add solution to problem 74 (TheAlgorithms#3110)
8582d89 
* Add solution to problem 74

* Fix typo

* Edit unnecessary comment

* Rename folder, add default params in solution()

* Rename file to solve conflicts

* Fix doctests
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@GGn0 @peRFectBeliever
Add solution to problem 74 (TheAlgorithms#3110)
70b6a99 
* Add solution to problem 74

* Fix typo

* Edit unnecessary comment

* Rename folder, add default params in solution()

* Rename file to solve conflicts

* Fix doctests
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@GGn0
Add solution to problem 74 (TheAlgorithms#3110)
b181e4f 
* Add solution to problem 74

* Fix typo

* Edit unnecessary comment

* Rename folder, add default params in solution()

* Rename file to solve conflicts

* Fix doctests
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@GGn0 @shermanhui
Add solution to problem 74 (TheAlgorithms#3110)
51d3872 
* Add solution to problem 74

* Fix typo

* Edit unnecessary comment

* Rename folder, add default params in solution()

* Rename file to solve conflicts

* Fix doctests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GGn0 @poyea @dhruvmanila