Skip to content

Hacktoberfest 2020 - Implement Python algorithms or data structures, fix existing ones and more! #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
poyea opened this issue Sep 30, 2020 · 55 comments
Assignees
Labels

Comments

@poyea
Copy link
Member

poyea commented Sep 30, 2020

The annual Hacktoberfest is around the corner! Register on Hacktoberfest's website and open 4 pull requests during October 2020 to receive the swags (if you're the first 70,000 participants)!

In our Python repository, there are currently several open issues:

What's more, you can also fix an existing bugs, improve any documentation and provide better implementations for certain algorithms! Feel free to inform the community by filling an issue and start hacking! If you're new to contributing code, please read our Contribution Guidelines for an overall understanding and ask questions on the internet - Google, StackOverflow or our Gitter.

TheAlgorithms has repositories in other programming languages, so find your language and start coding there!

What you can do to participate

  1. Read our Contribution Guidelines
  2. Comment below or open an issue (for big ideas you may want the community to know) on your new implementations, fixes or functionalities
  3. Start hacking!
  4. Open a pull request for your contribution
  5. Label your pull requests with hacktoberfest
  6. Wait until your pull requests get reviewed or merged! In the meantime, you can review someone else's pull requests too

Useful links

Remarks

  • Please observe Hacktoberfest's rules, terms and FAQ. If a pull request is marked invalid or spam it would not be counted and the person may be disqualified for the swags.
  • Hacktoberfest 2020 is an event presented by DigitalOcean, Intel and DEV.

Hacktoberfest's update

PRs count if:
Submitted in a repo with the hacktoberfest topic AND
during the month of October AND (
The PR is merged OR
The PR is labelled as hacktoberfest-accepted by a maintainer OR
The PR has been approved
)
https://hacktoberfest.digitalocean.com/hacktoberfest-update

@cclauss
Copy link
Member

cclauss commented Sep 30, 2020

PSA: I am checking out for the month of Hacktoberfest. I have some important work that I must attend to so I will stop contributing to this repo for the next 30 days. I would encourage maintainers to stick with the rules that have gotten us this far: be friendly, insist on best coding practices including all that is in CONTRIBUTING.md (functions, type hints, doctests, etc.)

If you see PRs that are useless or show that the contributor has not read CONTRIBUTING.md please mark those PRs with the invalid label and close them. (Hacktoberfest organizers look for the invalid label.) Do the same for any contributor who is disrespectful. If we consistently demonstrate that we have high standards and no tolerance for disrespect then the spamers will go elsewhere.

See you again in November.

@poyea
Copy link
Member Author

poyea commented Oct 3, 2020

Please observe that, from now on, a PR has to be marked hacktoberfest-accepted, approved or merged in order to be counted towards the event. For maintainers, please add the labels hacktoberfest-accepted to PRs that are NOT spams, even if you can't review those PRs at the moment. As usual, we label spams as invalid.

https://hacktoberfest.digitalocean.com/hacktoberfest-update

@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 3, 2020
the-kaustubh added a commit to the-kaustubh/Python that referenced this issue Oct 3, 2020
the-kaustubh added a commit to the-kaustubh/Python that referenced this issue Oct 3, 2020
@DmytroLitvinov
Copy link
Contributor

Hi @poyea ,
Mark please issue #2402 as resolved in the first message of that issue.

@poyea
Copy link
Member Author

poyea commented Oct 3, 2020

Sure.

@thevirtualbuddy
Copy link

Hi @poyea & other maintainers,
I am interested to contribute one of my projects to this repository.
The project is a simple CLI application (python based) which has the following functionalities:

  1. Encrypt and encode data in an image.
  2. Decode and decrypt data from an image.

It uses Caesar cipher (encryption & decryption) and Image Steganography(encoding & decoding).

Can I contribute it to this repository?

@poyea
Copy link
Member Author

poyea commented Oct 3, 2020

Yes. You may also see if there's any related implementation in ciphers.

@thevirtualbuddy
Copy link

thevirtualbuddy commented Oct 3, 2020

@poyea
Thank you for the quick response.
It has caesar cipher #1958 but it doesn't have image steganography combined with it.
So, should I work on the existing code or work fresh?

Or should I create a new folder as Image Steganography?

@poyea
Copy link
Member Author

poyea commented Oct 3, 2020

You may add a new one, as the current one works with strings, unless you can modify it make it compatible with images or matrices.

@thevirtualbuddy
Copy link

Thank you @poyea
I will add a new folder as Image Steganography.

@cclauss
Copy link
Member

cclauss commented Oct 3, 2020

Please create a new directory only if there are going to be multiple Python files in it. If it is just a single Python file then please find and existing directory to put it in. We do not want to force visitors to click into and out of tons of directories to find something of interest.

@poyea
Copy link
Member Author

poyea commented Oct 3, 2020

Yes, add a folder if you have images related to that, but in general, we want to avoid this.

@thevirtualbuddy
Copy link

I am a bit confused here now :').
If I should add it in Ciphers as caesar_ciphers_with_steganography or create a new folder?

@cclauss
Copy link
Member

cclauss commented Oct 3, 2020

How many Python files will your proposed new folder contain?

@thevirtualbuddy
Copy link

thevirtualbuddy commented Oct 3, 2020

@cclauss I can combine all the files in a single file. Right now, I have the files divided as caesar.py, steganography.py and driver.py
So, only one file.

@cclauss
Copy link
Member

cclauss commented Oct 3, 2020

Cool. Then do it whichever way that you think best. Thanks.

@MonarchChakri
Copy link

Hi @cclauss / @poyea
Added file_utils.py under others and created a PR #2735
A utility files helpful for all common file IO.
Please review and merge.

@MonarchChakri MonarchChakri mentioned this issue Oct 4, 2020
10 tasks
@dickyw71
Copy link
Contributor

dickyw71 commented Oct 4, 2020

Hi @poyea & other maintainers,

I have a fix for issue #1901 and I would like to submit.

My YAML Workflow file auto-closes empty issues.
The file-path name is .github/workflows/auto_close_empty_issues.yml.

The workflow checks whether a new issue body is empty and if so it uses the close-issue action to auto-close the issue and send a notification email to the repo owner/maintainers.

I have tested the Workflow works as expected in my own repo.

Is is ok for me to raise a PR?

@FirePing32
Copy link
Contributor

Hey @cclauss @poyea Can i add some chemical conversitions to /conversions as a part of hacktoberfest ?

@breezko
Copy link

breezko commented Oct 4, 2020

I’ve added #2782

@dhruvmanila
Copy link
Member

As mentioned, please include for Hacktoberfest or something like that in your description to signal us that this PR is for Hacktoberfest otherwise we wouldn't know that you participated or not.

@Ed1123
Copy link

Ed1123 commented Oct 13, 2020

Hi, this'd be my first PR to a public repo so I'd like to keep it very small (very). I'm starting by improving the documentation for this two algorithms (newton_method.py and newton_raphson.py).

I know it is a small contribution and know that it may not count towards Hacktoberfest. If you have any feedback on how to make it count I'm all ears eyes. 😄
If there is no way it can count it'd ok. It will serve me to get familiarized with how Github and PR's work (I'm following this tutorial by DigitalOcean for that).

Hi @poyea, I came across with an implementation of the secand method in which many improvements can be done. Should I just modify that file or add a new algorithm?

@KaLiMaLi555
Copy link

Hi, I wanted to add a implementation for a Data-structure called KD-Tree. It has various uses like multi-dimensional partitioning and searching. Is it a nice idea? If so where should I add it?

@dark00infinity
Copy link

solution of euler problem38 added #3452 . all checkpoint pass

@cybov
Copy link
Contributor

cybov commented Oct 18, 2020

Can someone pls look into my PR #3420

@shabab477
Copy link
Contributor

@cclauss, @poyea could you look into 3468

@skhurana852
Copy link

Hi, I would like to add implementation for Banker's Algorithm which is a deadlock detection algorithm that uses 2d arrays. Can I contribute?

@cclauss
Copy link
Member

cclauss commented Oct 20, 2020

@skhurana852 https://github.com/TheAlgorithms/Python/search?q=Banker

@BasilVictor
Copy link

@poyea or any of the other project maintainers, I have created a program and have created a PR, but there has been no response of any sort 😔
Can someone review #3512 and give any feedback if any, so that even I can contribute here.

@cclauss
Copy link
Member

cclauss commented Oct 21, 2020

@BasilVictor There are 460+ open PRs on this repo and before Hacktoberfest started there were 30.
All maintainers are snowed under with the silliness of Hacktoberfest on a set of tasks that we do for no remuneration.

Is your algorithm (#3512) really differentiated from / better than the four pages of other distance algorithms in this repo? You have checked the box I have read CONTRIBUTING.md. but your submission contains no type hints, no doctests, a function name that is not in snake_case, and no URL to a source describing the algorithm.

@GGn0
Copy link
Contributor

GGn0 commented Oct 25, 2020

Hello maintainers!
I think there might be a problem with the PR #3110
One of the two Travis CI checks seems to be still in progress (for over 16 days!)
but clicking the details shows that the build passed after 19 minutes here's a link to the build

@SOUMEE2000
Copy link

Hello @cclauss. This is my first time contributing to anything. So basically, I submitted three PR s that are for the c language directory. A stupid question, but can they be thought of as participating for hactoberfest?

@shabab477
Copy link
Contributor

@dhruvmanila @cclauss, @poyea could you look into 3468. Thanks!

@cclauss
Copy link
Member

cclauss commented Oct 26, 2020

@shabab477 #2510 (comment)

@sonechca
Copy link

I would like to create a web crawler to find jobs at StackOverFlow :)

@cclauss
Copy link
Member

cclauss commented Oct 29, 2020

Just do it!

@shabab477
Copy link
Contributor

@sonechca would definitely use the script

@cclauss cclauss closed this as completed Nov 1, 2020
@cclauss
Copy link
Member

cclauss commented Nov 1, 2020

We started with 30 open PRs and ended with 521.

@shabab477
Copy link
Contributor

Thank you, all the maintainers of this project for showing patience while participating in this event. Love you all <3

@dhruvmanila dhruvmanila unpinned this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.