Skip to content

Add default args and type hints for Project Euler problem 7 #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2020
Merged

Add default args and type hints for Project Euler problem 7 #2973

merged 1 commit into from
Oct 8, 2020

Conversation

dhruvmanila
Copy link
Member

Continuing #2786

  • Add default argument values
  • Add type hints
  • Change one letter variable names to a more descriptive one
  • Add doctest for solution()

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.

@dhruvmanila
Add default args and type hints for problem 7
26a797d 
- Add default argument values
- Add type hints
- Change one letter variable names to a more descriptive one
- Add doctest for `solution()`
@dhruvmanila dhruvmanila added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2020
@dhruvmanila dhruvmanila mentioned this pull request Oct 8, 2020
Closed
cclauss
cclauss approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss cclauss merged commit 719c556 into TheAlgorithms:master Oct 8, 2020
@dhruvmanila dhruvmanila deleted the patch-problem-7 branch October 8, 2020 06:02
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@dhruvmanila @stokhos
Add default args and type hints for problem 7 (TheAlgorithms#2973)
a0099fd 
- Add default argument values
- Add type hints
- Change one letter variable names to a more descriptive one
- Add doctest for `solution()`
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila
Add default args and type hints for problem 7 (TheAlgorithms#2973)
37a337c 
- Add default argument values
- Add type hints
- Change one letter variable names to a more descriptive one
- Add doctest for `solution()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

@realDuYuanChao realDuYuanChao Awaiting requested review from realDuYuanChao

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @cclauss