Skip to content

Should we implement CODEOWNERS for the directories of this repo? #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cclauss opened this issue Oct 7, 2020 · 3 comments · Fixed by #3147
Closed

Should we implement CODEOWNERS for the directories of this repo? #3011

cclauss opened this issue Oct 7, 2020 · 3 comments · Fixed by #3147
Labels

Comments

@cclauss
Copy link
Member

cclauss commented Oct 7, 2020

https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners

Maintainers could volunteer to be assigned to all new PRs for particular folders in the repo this would mean that a maintainer would have 5 or 10 pull requests to review in topic areas that they are interested in instead of wading thru the current 224 open PRs.

@dhruvmanila
Copy link
Member

This would be extremely useful but there's some caveats:

  • We have over dozens of directories (around 40)
  • If a maintainer is responsible for 5 directories, we need over 8 of them. This is assuming that we will divide it by 5, if it is less, then more number of maintainers will be required.
  • I might be wrong but I don't think we have that many active maintainers.

@cclauss
Copy link
Member Author

cclauss commented Oct 8, 2020

Is it possible to start with a partial implementation? Just a few directories are assigned to just a few maintainers and the other directories continue to have no owners? I would be interested to be assigned:

  • .github
  • ciphers
  • conversions
  • data_structures
  • others
  • strings
  • web_programming

@dhruvmanila
Copy link
Member

Yeah that would be fine. I haven't actually looked at all the directories to decide for myself, but to start I will take the entire project_euler directory. I am also interested in Machine Learning and Neural Networks.

I will create a PR for this but before that can you take a look at #2973 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants