Skip to content

Add molecular_chemistry.py #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 10, 2020
Merged

Add molecular_chemistry.py #2944

merged 8 commits into from
Nov 10, 2020

Conversation

FirePing32
Copy link
Contributor

@FirePing32 FirePing32 commented Oct 6, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@FirePing32 FirePing32 closed this Oct 6, 2020
@FirePing32 FirePing32 reopened this Oct 6, 2020
@FirePing32
Copy link
Contributor Author

@cclauss @poyea Please see this. #2765 is merged but I am still getting a pre-commit error. All tests have passed.

@cclauss
Copy link
Member

cclauss commented Oct 6, 2020 •
edited
Loading

There are 200+ open pull requests on this repo. Please do not @mention maintainers on your pull request because you believe that it is more important than the others. We have our hands full with the silliness of Hacktoberfest and this is not something that we are paid to do.

@FirePing32 FirePing32 mentioned this pull request Oct 6, 2020
Closed
2 tasks
@FirePing32
Copy link
Contributor Author

FirePing32 commented Oct 7, 2020 •
edited
Loading

@poyea @dhruvmanila All checks and actions have passed. Please merge.

Can you also add hacktoberfest-accepted label to this PR ?

@FirePing32
Copy link
Contributor Author

I think this looks good @dhruvmanila . Can you give a review about it ?

cclauss
cclauss requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this submission also plagiarism like #2983 (comment) was?

@FirePing32
Copy link
Contributor Author

FirePing32 commented Oct 7, 2020 •
edited by cclauss
Loading

No...this is my own code

@NicholasACTran
Copy link

Ignoring whether this is plagiarism or not, does this count as an "algorithm" in the computer science theoretic sense?

@FirePing32
Copy link
Contributor Author

Ignoring whether this is plagiarism or not, does this count as an "algorithm" in the computer science theoretic sense?

@NicholasACTran There are also temperature conversion in conversions. This PR also belongs to the same category. And this is NOT plagiarised.

@cclauss
Copy link
Member

cclauss commented Oct 8, 2020

@NicholasACTran Our barrier is purposefully low on evaluating if contributions count as an algorithm in the computer science theoretic sense because that line is difficult to draw and because we are attempting to attract contributions from people who are not (yet) computer science experts.

@NicholasACTran
Copy link

NicholasACTran commented Oct 8, 2020 •
edited
Loading

Thanks for the clarification.

@FirePing32
Copy link
Contributor Author

FirePing32 commented Oct 8, 2020 •
edited by dhruvmanila
Loading

So will you merge this ?

@dhruvmanila
Copy link
Member

As mentioned please don't @mention maintainers. We already have hundreds of PRs to go through so have patience and we will take a look at it.

@FirePing32
Copy link
Contributor Author

Any update?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Used to mark an issue or pull request stale. label Nov 10, 2020
@FirePing32
Copy link
Contributor Author

@cclauss @dhruvmanila Please tell whether this PR will be merged or not. It was marked stale.

cclauss
cclauss approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@cclauss cclauss merged commit a6ad25c into TheAlgorithms:master Nov 10, 2020
@FirePing32 FirePing32 deleted the add/mol-chem branch November 10, 2020 11:24
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@FirePing32 @cclauss @stokhos
Add molecular_chemistry.py (TheAlgorithms#2944)
0569c19 
* Create molecular_chemistry.py

* round up outputs

* Remove floating point

* Add Wikipedia references

* fixup! Format Python code with psf/black push

* Add Conversions/Molecular Chemistry

* updating DIRECTORY.md

* Update molecular_chemistry.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@FirePing32 @cclauss @peRFectBeliever
Add molecular_chemistry.py (TheAlgorithms#2944)
61f122e 
* Create molecular_chemistry.py

* round up outputs

* Remove floating point

* Add Wikipedia references

* fixup! Format Python code with psf/black push

* Add Conversions/Molecular Chemistry

* updating DIRECTORY.md

* Update molecular_chemistry.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@FirePing32 @cclauss
Add molecular_chemistry.py (TheAlgorithms#2944)
b4ac5be 
* Create molecular_chemistry.py

* round up outputs

* Remove floating point

* Add Wikipedia references

* fixup! Format Python code with psf/black push

* Add Conversions/Molecular Chemistry

* updating DIRECTORY.md

* Update molecular_chemistry.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@FirePing32 @cclauss @shermanhui
Add molecular_chemistry.py (TheAlgorithms#2944)
00bcb80 
* Create molecular_chemistry.py

* round up outputs

* Remove floating point

* Add Wikipedia references

* fixup! Format Python code with psf/black push

* Add Conversions/Molecular Chemistry

* updating DIRECTORY.md

* Update molecular_chemistry.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
stale Used to mark an issue or pull request stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FirePing32 @cclauss @NicholasACTran @dhruvmanila