Skip to content

Hacktoberfest - Added a solution to Project Euler 72 #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2020
Merged

Hacktoberfest - Added a solution to Project Euler 72 #2940

merged 3 commits into from
Oct 12, 2020

Conversation

c-utkarsh
Copy link
Contributor

Describe your change:

Added a solution to the Project Euler 72 - Counting fractions

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@c-utkarsh
Copy link
Contributor Author

Review request, @dhruvmanila

dhruvmanila
dhruvmanila requested changes Oct 12, 2020
View reviewed changes
@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 12, 2020
@dhruvmanila dhruvmanila reopened this Oct 12, 2020
@c-utkarsh
Copy link
Contributor Author

Hi @dhruvmanila, I've incorporated the suggested changes. Have a look.

@dhruvmanila dhruvmanila merged commit 8f8d39d into TheAlgorithms:master Oct 12, 2020
@dhruvmanila dhruvmanila removed the awaiting changes A maintainer has requested changes to this PR label Oct 12, 2020
@c-utkarsh c-utkarsh deleted the add_problem_72 branch October 12, 2020 14:22
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@c-utkarsh @stokhos
Add a solution to Project Euler 72 (TheAlgorithms#2940)
d73247d 
* Added Problem 72

* Removed args from solution()

* Incorporated the suggested changes
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@c-utkarsh
Add a solution to Project Euler 72 (TheAlgorithms#2940)
c5a8030 
* Added Problem 72

* Removed args from solution()

* Incorporated the suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksr1122 ksr1122 ksr1122 approved these changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-utkarsh @ksr1122 @dhruvmanila