Skip to content

Hacktoberfest: Add a solution for Project Euler 50 #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

Hacktoberfest: Add a solution for Project Euler 50 #2703

wants to merge 20 commits into from

Conversation

Iqrar99
Copy link
Contributor

@Iqrar99 Iqrar99 commented Oct 3, 2020 •
edited
Loading

Seperated the PR based on #2548 and ref #2695

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Iqrar99 and others added 15 commits February 20, 2020 18:03
@Iqrar99
added doctests in modular_exponential.py
0da5cea
@Iqrar99
Merge branch 'master' of https://github.com/Iqrar99/Python
e658085
@Iqrar99
added doctests in modular_exponential.py
4183239
@Iqrar99
added URL link
3856fa0
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
82aed44
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
d3a4913
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
b4e33ab
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
133838c
updating DIRECTORY.md
cb8ab38
@Iqrar99
Add problem 50 solution
7824282
@Iqrar99
Merge branch 'pe-50' of https://github.com/Iqrar99/Python into pe-50
8dbef02
updating DIRECTORY.md
c933fe8
@Iqrar99
Fix some mistakes
a2acaf8
@Iqrar99
Merge branch 'pe-50' of https://github.com/Iqrar99/Python into pe-50
f4b32b2
@Iqrar99
Move the import statement lower
e75158b
@Iqrar99 Iqrar99 mentioned this pull request Oct 5, 2020
Merged
14 tasks
@Iqrar99 Iqrar99 changed the title Add a solution for Project Euler 50 Hacktoberfest: Add a solution for Project Euler 50 Oct 5, 2020
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 5, 2020
@Iqrar99 Iqrar99 requested a review from dhruvmanila October 11, 2020 07:58
dhruvmanila
dhruvmanila requested changes Oct 12, 2020
View reviewed changes
@Iqrar99
Improve the code
c45bfe3 
* Add type hint
* Add more tests
* Add problem link
@Iqrar99
Small fix
e51429f
@Iqrar99 Iqrar99 requested a review from dhruvmanila October 12, 2020 05:59
dhruvmanila
dhruvmanila reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement:

@Iqrar99

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.

@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR merge conflicts Open a new PR or rebase on the latest commit labels Oct 16, 2020
@Iqrar99
Copy link
Contributor Author

Iqrar99 commented Oct 17, 2020

Alright, I'll fix this soon

@dhruvmanila dhruvmanila reopened this Oct 17, 2020
@dhruvmanila dhruvmanila reopened this Oct 17, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@stale
Copy link

stale bot commented Dec 10, 2020

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale bot closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila requested changes

Assignees
No one assigned
Labels
awaiting changes A maintainer has requested changes to this PR hacktoberfest-accepted Accepted to be counted towards Hacktoberfest merge conflicts Open a new PR or rebase on the latest commit stale Used to mark an issue or pull request stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Iqrar99 @dhruvmanila @poyea