-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Hacktoberfest: Add a solution for Project Euler 49 #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the review @dhruvmanila. I'll make the changes soon. |
These fixes are intended to follow the CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for your contribution. 🎉 😃
Co-authored-by: Dhruv <[email protected]>
You are welcome! Maybe you want to review my Project Euler 50 PR? @dhruvmanila here #2703 |
Sure thing, but please keep this in mind that we receive a lot of PRs and if possible only submit one PR at a time and once that is approved, submit another one. The ocean is made up of tiny droplets of water |
I see. Take your time 😄 |
Are you participating in Hacktoberfest? If so, please include for Hacktoberfest in the description of your PR to signal us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much 😄 I'm looking forward to contributing more! |
* added doctests in modular_exponential.py * added doctests in modular_exponential.py * added URL link * updating DIRECTORY.md * Add problem 49 solution * updating DIRECTORY.md * Fix several mistakes These fixes are intended to follow the CONTRIBUTING.md * Move the import statements lower * Update project_euler/problem_49/sol1.py Co-authored-by: Dhruv <[email protected]> Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Dhruv <[email protected]>
* added doctests in modular_exponential.py * added doctests in modular_exponential.py * added URL link * updating DIRECTORY.md * Add problem 49 solution * updating DIRECTORY.md * Fix several mistakes These fixes are intended to follow the CONTRIBUTING.md * Move the import statements lower * Update project_euler/problem_49/sol1.py Co-authored-by: Dhruv <[email protected]> Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Dhruv <[email protected]>
Seperated the PR based on #2548
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}
.