Skip to content

Add a solution for Project Euler 49 and 50 #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Add a solution for Project Euler 49 and 50 #2548

wants to merge 16 commits into from

Conversation

Iqrar99
Copy link
Contributor

@Iqrar99 Iqrar99 commented Oct 1, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Iqrar99 and others added 16 commits February 20, 2020 18:03
@Iqrar99
added doctests in modular_exponential.py
0da5cea
@Iqrar99
Merge branch 'master' of https://github.com/Iqrar99/Python
e658085
@Iqrar99
added doctests in modular_exponential.py
4183239
@Iqrar99
added URL link
3856fa0
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
82aed44
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
d3a4913
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
b4e33ab
@Iqrar99
Add project euler problem_49 solution
e3fa97f
@Iqrar99
Add project euler problem_50 solution
7ef4fac
fixup! Format Python code with psf/black push
d30669b
@Iqrar99
Fix typo
a0a2941
@Iqrar99
Merge branch 'project-euler' of https://github.com/Iqrar99/Python int…
8adb7c1 
…o project-euler
updating DIRECTORY.md
6dc7bef
@Iqrar99
Fix flake8 errors
581c44d
@Iqrar99
Merge branch 'project-euler' of https://github.com/Iqrar99/Python int…
e04d9db 
…o project-euler
@Iqrar99
Fix return type
ed5d00e
@Iqrar99
Copy link
Contributor Author

Iqrar99 commented Oct 1, 2020

Feel free to review my commits @poyea

@dhruvmanila
Copy link
Member

Hey, awesome work and thank you for your contribution but as mentioned in CONTRIBUTING.md, please open two separate PRs for different algorithms.

  • Close this PR and open two new ones each containing a single algorithm

@Iqrar99
Copy link
Contributor Author

Iqrar99 commented Oct 3, 2020

Okay

This was referenced Oct 3, 2020
Closed
Merged
@Iqrar99
Copy link
Contributor Author

Iqrar99 commented Oct 3, 2020

I already divided the PR. @dhruvmanila

@Iqrar99 Iqrar99 closed this Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iqrar99 @dhruvmanila