Web programming contribution

[niranjan195]

Describe your change:

Added Currency Converter Program to web_programming directory.

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[TravisBuddy]

Hey @niranjanhegde144,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 62e11780-f812-11ea-8f9f-a900ee46d44b

[niranjan195]

Clauss Can you take a look at this

[cclauss]

We need to change this. For security reasons, we do not want to encourage users to put security credentials into Python files. Instead, we will get the key at runtime from an environment variable.

The user will run the program with this command:
AMDOREN_API_KEY="This is my key" python3 web_programming/currency_converter.py

Suggested change

	import requests
	API_KEY = "" # <-- Put your API Key here
	import os
	import requests
	assert API_KEY := os.environ["AMDOREN_API_KEY"], (
	"Please put your API key in an environment variable."
	)

[cclauss]

Suggested change

	def convert_currency(
	baseCurrency: str = "USD",
	targetCurrency: str = "INR",
	amount: float = 1.0,
	apiKey: str = API_KEY,
	) -> str:
	"""https://www.amdoren.com/currency-api/"""
	res = requests.get(
	f"{URL_BASE}?api_key={API_KEY}&from={baseCurrency}&to={targetCurrency}&\
	amount={amount}"
	).json()
	if res["error"] == 0:
	return str(res["amount"])
	return res["error_message"]
	def convert_currency(
	from_: str = "USD",
	to: str = "INR",
	amount: float = 1.0,
	api_key: str = API_KEY
	) -> str:
	"""https://www.amdoren.com/currency-api/"""
	params = locals()
	params["from"] = params.pop("from_") # 'from' is a Python keyword
	res = requests.get(URL_BASE, params=params).json()
	return str(res["amount"] if res["error"] == 0 else res["error_message"])

There are nice advantages in requests and locals() if our function parameter names exactly match the API.

[cclauss]

Suggested change

	base_currency = input("Enter base currency: ").strip()
	target_currency = input("Enter target currency: ").strip()
	amount = float(input("Enter the amount: ").strip())
	print(
	convert_currency(
	baseCurrency=base_currency, targetCurrency=target_currency, amount=amount
	)
	)
	print(
	convert_currency(
	input("Enter from currency: ").strip(),
	input("Enter to currency: ").strip(),
	float(input("Enter the amount: ").strip())
	)
	)

[TravisBuddy]

Hey @niranjanhegde144,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 61ca28d0-ffdf-11ea-9882-0125ab0f75bf

[TravisBuddy]

Travis tests have failed

Hey @niranjanhegde144,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 268e7950-ffe0-11ea-9882-0125ab0f75bf

[cclauss]

https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.