Skip to content

writing test for min cost string conversion #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

writing test for min cost string conversion #2392

wants to merge 6 commits into from

Conversation

meysam81
Copy link
Contributor

@meysam81 meysam81 commented Sep 3, 2020 •
edited
Loading

also modified the main script to be testable

I also had to change the line that handled delete section

Fixes #2128

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@meysam81
writing test for min cost string conversion
43ea6d6 
also modified the main script to be testable

I also had to change the line that handled `delete` section

Fixes #2128
@meysam81
string-conversion: modified costs, and passed arguments to map with…
66f4342 
…out unpacking

also renamed a variable `create` to `copy`
@meysam81
strings: modified cost of different operations when testing string-co…
0ca9ada 
…nversion
@stale
Copy link

stale bot commented Oct 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Oct 10, 2020
@meysam81
Copy link
Contributor Author

@cclauss
Will you consider this PR please?

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Oct 10, 2020
@cclauss
Copy link
Member

cclauss commented Oct 10, 2020

#2510 (comment)

@meysam81
Copy link
Contributor Author

@poyea
Hi there 😅

@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@poyea
Copy link
Member

poyea commented Nov 26, 2020

Thanks. Could you also add some type hints for these functions?

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Nov 26, 2020
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 26, 2020
@ghost ghost added require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html and removed awaiting reviews This PR is ready to be reviewed labels Nov 26, 2020
@meysam81 meysam81 requested a review from cclauss as a code owner November 26, 2020 07:29
@ghost
Copy link

ghost commented Nov 26, 2020

Closing this pull request as invalid

@meysam81, this pull request is being closed as the files submitted contains no extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first.

@ghost ghost added the invalid label Nov 26, 2020
@ghost ghost closed this Nov 26, 2020
@ghost ghost removed request for cclauss, l3str4nge and Kush1101 November 26, 2020 07:29
@ghost ghost removed the request for review from dhruvmanila November 26, 2020 07:29
@meysam81
Copy link
Contributor Author

@poyea
I only merged the master into the code 😐
It has been a long time since I opened this pull request and its obvious that a lot has changed since.
Could you please reopen it?

@dhruvmanila
Copy link
Member

This pull request should not be reopened. Also, you should rebase instead of merging, as you can see you have added 436 files in this pull request. So, whatever you were trying to submit, please open a new pull request for it after branching off from the latest master.

@meysam81 meysam81 mentioned this pull request Nov 26, 2020
Closed
14 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev sprint ideas: More tests, type hints and less complexity
4 participants
@meysam81 @cclauss @poyea @dhruvmanila