Skip to content

Added a binomial distribution formula calculator algorithm #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 13, 2020
36 changes: 14 additions & 22 deletions maths/binomial_distribution.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,12 @@
https://en.wikipedia.org/wiki/Binomial_distribution"""


def binomial_distribution(k, n, p) -> float:
def binomial_distribution(successes: int, trials: int, prob: float) -> float:
"""

Returns probability of k successes out of n tries,
with p probability for one success

use: binomial_distribution(k, n, p):
k - successes
n - independent Bernoulli trials
p - probability for one succes

The function uses the factorial function
in order to calculate the binomial coefficient

Expand All @@ -22,22 +17,20 @@ def binomial_distribution(k, n, p) -> float:
>>> binomial_distribution (2, 4, 0.5)
0.375

>>> binomial_distribution (2, 4, -0.5)
Traceback (most recent call last):
...
raise ValueError("p - Probability has to be in range of 1 - 0")
ValueError: p - Probability has to be in range of 1 - 0
"""
if k > n:
raise ValueError("""k must be lower or equal to n""")
if n < 0 or k < 0 or type(k) != int or type(n) != int:
raise ValueError("the function is defined for non-negative integers k and n")
if p > 1 or p < 0:
raise ValueError("p - Probability has to be in range of 1 - 0")
probability = (p**k)*(1-p)**(n-k)
if successes > trials:
raise ValueError("""successes must be lower or equal to trials""")
if trials < 0 or successes < 0:
raise ValueError("the function is defined for non-negative integers")
if type(successes) != int or type(trials) != int:
raise ValueError("the function is defined for non-negative integers")
if prob > 1 or prob < 0:
raise ValueError("prob has to be in range of 1 - 0")
probability = (prob**successes)*(1-prob)**(trials-successes)
# Calculate the binomial coefficient:
# Calculate n! / k!(n-k)!
coefficient = factorial(n)/(factorial(k)*factorial(n-k))
coefficient = factorial(trials)
coefficient /= (factorial(successes)*factorial(trials-successes))

return probability * coefficient

Expand All @@ -61,6 +54,5 @@ def factorial(n) -> int:
return result

if __name__ == "__main__":
print ("Probability of 2 successes out of 4 trails")
print ("with probability of 0.75 is : ")
print (str(binomial_distribution(2, 4, 0.75)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave these three lines in place if you want.

from doctest import testmod
testmod()