-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
Another method added for GCD #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fd6f80a
Another method added for GCD
subahanii c9630ef
Now doctest fulfilled for added method.
subahanii 70ed30d
Update greatest_common_divisor.py
subahanii da5ad7b
Now unnecessary white spaces removed.
subahanii e29cf99
Cycle_Detection_Undirected_Graph
subahanii 5857599
Update greatest_common_divisor.py again
subahanii 4cb4de9
Again Updated cycle_detection_undirected_graph.py
subahanii dc102f4
Delete cycle_detection_undirected_graph.py
cclauss 1826027
Add doctests and format the code with psf/black
cclauss b435abb
fixup: Typo
cclauss 60aeb51
Update greatest_common_divisor.py
cclauss 5a96d12
greatest_common_divisor()
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,15 @@ | |
""" | ||
|
||
|
||
|
||
# This method is more efficient not acquire more memory cause is no use of any stacks like in recursive as next below mentioned. | ||
def gcd_by_iterative(x,y): | ||
while y:x,y=y,x%y | ||
|
||
return x | ||
|
||
|
||
|
||
def gcd(a, b): | ||
"""Calculate Greatest Common Divisor (GCD).""" | ||
return b if a == 0 else gcd(b % a, a) | ||
|
@@ -16,10 +25,14 @@ def main(): | |
nums = input("Enter two Integers separated by comma (,): ").split(",") | ||
num_1 = int(nums[0]) | ||
num_2 = int(nums[1]) | ||
|
||
print(f"gcd({num_1}, {num_2}) = {gcd(num_1, num_2)}") | ||
print(f"By iterative gcd({num_1}, {num_2}) = {gcd_by_iterative(num_1, num_2)}") | ||
|
||
except (IndexError, UnboundLocalError, ValueError): | ||
print("Wrong Input") | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please lose this whitespace. |
||
if __name__ == "__main__": | ||
main() | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this over two lines for readability.
Please add doctests to both functions. See CONTRIBUTING.md for details.