Skip to content

Another method added for GCD #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 22, 2019
Merged

Another method added for GCD #1387

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fd6f80a
Another method added for GCD
subahanii Oct 17, 2019
c9630ef
Now doctest fulfilled for added method.
subahanii Oct 18, 2019
70ed30d
Update greatest_common_divisor.py
subahanii Oct 18, 2019
da5ad7b
Now unnecessary white spaces removed.
subahanii Oct 18, 2019
e29cf99
Cycle_Detection_Undirected_Graph
subahanii Oct 19, 2019
5857599
Update greatest_common_divisor.py again
subahanii Oct 20, 2019
4cb4de9
Again Updated cycle_detection_undirected_graph.py
subahanii Oct 20, 2019
dc102f4
Delete cycle_detection_undirected_graph.py
cclauss Oct 22, 2019
1826027
Add doctests and format the code with psf/black
cclauss Oct 22, 2019
b435abb
fixup: Typo
cclauss Oct 22, 2019
60aeb51
Update greatest_common_divisor.py
cclauss Oct 22, 2019
5a96d12
greatest_common_divisor()
cclauss Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion maths/greatest_common_divisor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@
"""



# This method is more efficient not acquire more memory cause is no use of any stacks like in recursive as next below mentioned.
def gcd_by_iterative(x,y):
while y:x,y=y,x%y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this over two lines for readability.
Please add doctests to both functions. See CONTRIBUTING.md for details.


return x



def gcd(a, b):
"""Calculate Greatest Common Divisor (GCD)."""
return b if a == 0 else gcd(b % a, a)
Expand All @@ -16,10 +25,14 @@ def main():
nums = input("Enter two Integers separated by comma (,): ").split(",")
num_1 = int(nums[0])
num_2 = int(nums[1])

print(f"gcd({num_1}, {num_2}) = {gcd(num_1, num_2)}")
print(f"By iterative gcd({num_1}, {num_2}) = {gcd_by_iterative(num_1, num_2)}")

except (IndexError, UnboundLocalError, ValueError):
print("Wrong Input")


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lose this whitespace.

if __name__ == "__main__":
main()