Another method added for GCD #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
requested changes
Oct 18, 2019
maths/greatest_common_divisor.py
Outdated
|
|
||
| # This method is more efficient not acquire more memory cause is no use of any stacks like in recursive as next below mentioned. | ||
| def gcd_by_iterative(x,y): | ||
| while y:x,y=y,x%y |
There was a problem hiding this comment.
Please split this over two lines for readability.
Please add doctests to both functions. See CONTRIBUTING.md for details.
subahanii
commented
Oct 18, 2019
cclauss
reviewed
Oct 18, 2019
maths/greatest_common_divisor.py
Outdated
| except (IndexError, UnboundLocalError, ValueError): | ||
| print("Wrong Input") | ||
|
|
||
|
|
||
Cycle_Detection_Undirected_Graph using Disjoint set DataStructure
I am not getting where is problem. Please Marge this all is right. |
Why you have marked as "Automated test is failing". |
cclauss
approved these changes
Oct 22, 2019
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Another method added for GCD * Now doctest fulfilled for added method. * Update greatest_common_divisor.py * Now unnecessary white spaces removed. * Cycle_Detection_Undirected_Graph Cycle_Detection_Undirected_Graph using Disjoint set DataStructure * Update greatest_common_divisor.py again * Again Updated cycle_detection_undirected_graph.py * Delete cycle_detection_undirected_graph.py * Add doctests and format the code with psf/black * fixup: Typo * Update greatest_common_divisor.py * greatest_common_divisor()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.