Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created mnist_classifier.py - Classifying MNIST dataset using a modified AlexNet #12325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created mnist_classifier.py - Classifying MNIST dataset using a modified AlexNet #12325
Changes from 2 commits
5b185ff
d45f819
3eda592
96af310
488d56c
d07977f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 2 in computer_vision/mnist_classifier.py
Ruff (E501)
Check failure on line 2 in computer_vision/mnist_classifier.py
Ruff (W291)
Check failure on line 3 in computer_vision/mnist_classifier.py
Ruff (E501)
Check failure on line 3 in computer_vision/mnist_classifier.py
Ruff (W291)
Check failure on line 7 in computer_vision/mnist_classifier.py
Ruff (E501)
Check failure on line 15 in computer_vision/mnist_classifier.py
Ruff (PLR0402)
Check failure on line 17 in computer_vision/mnist_classifier.py
Ruff (PLR0402)
Check failure on line 19 in computer_vision/mnist_classifier.py
Ruff (N812)
Check failure on line 20 in computer_vision/mnist_classifier.py
Ruff (PLR0402)
Check failure on line 23 in computer_vision/mnist_classifier.py
Ruff (I001)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
forward
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
computer_vision/mnist_classifier.py
, please provide doctest for the functionforward
Please provide type hint for the parameter:
x
Please provide descriptive name for the parameter:
x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
load_subset
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
computer_vision/mnist_classifier.py
, please provide doctest for the functionload_subset
Please provide type hint for the parameter:
full_train_set
Please provide type hint for the parameter:
full_test_set
Please provide type hint for the parameter:
label_one
Please provide type hint for the parameter:
label_two