Created mnist_classifier.py - Classifying MNIST dataset using a modified AlexNet #12325
Conversation
Python program using the provided template to train and test a MNIST dataset using a modified AlexNet model. The program should accept three integers as command line input. First two integers define the labels of the two-class classification and third integer represents the number of epochs for training.
Uppercase to lowercase rename.
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
for more information, see https://pre-commit.ci
|
The doctests are given. The comments are given and resolved for each function and variables. |
|
@algorithms-keeper review |
modified the file
for more information, see https://pre-commit.ci
|
modified the file |
modified mnist_classifier.py
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class AlexNet(n.Module): | ||
| def __init__(self, num): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: num
| n.Linear(1024, 10), | ||
| ) | ||
|
|
||
| def forward(self, x): |
There was a problem hiding this comment.
Please provide return type hint for the function: forward. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/mnist_classifier.py, please provide doctest for the function forward
Please provide type hint for the parameter: x
Please provide descriptive name for the parameter: x
| return x | ||
|
|
||
|
|
||
| def load_subset(full_train_set, full_test_set, label_one, label_two): |
There was a problem hiding this comment.
Please provide return type hint for the function: load_subset. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/mnist_classifier.py, please provide doctest for the function load_subset
Please provide type hint for the parameter: full_train_set
Please provide type hint for the parameter: full_test_set
Please provide type hint for the parameter: label_one
Please provide type hint for the parameter: label_two
| return train_set, test_set | ||
|
|
||
|
|
||
| def train(model, optimizer, train_loader, epoch): |
There was a problem hiding this comment.
Please provide return type hint for the function: train. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/mnist_classifier.py, please provide doctest for the function train
Please provide type hint for the parameter: model
Please provide type hint for the parameter: optimizer
Please provide type hint for the parameter: train_loader
Please provide type hint for the parameter: epoch
| optimizer.step() | ||
|
|
||
|
|
||
| def test(model, test_loader): |
There was a problem hiding this comment.
Please provide return type hint for the function: test. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/mnist_classifier.py, please provide doctest for the function test
Please provide type hint for the parameter: model
Please provide type hint for the parameter: test_loader
|
modified the code. |
|
Closing require_type_hints PRs to prepare for Hacktoberfest |
Python program to train and test a MNIST dataset using a modified AlexNet model.
The program should accept three integers as
command line input. First two integers define the labels of the two-class classification and third integer represents the number of epochs for training.
Describe your change:
Checklist: