Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flash sort algorithm implementation #11970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flash sort algorithm implementation #11970
Changes from 1 commit
476ccc3
aa24123
5dd34bd
e7073ae
5c08b2d
098147f
76aff03
23655a4
322398a
d6da2d6
e6e020e
4cb1146
5e8de60
4422644
6518ffa
50e3583
ab40ed1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 1 in sorts/flash_sort.py
Ruff (C901)
Check failure on line 21 in sorts/flash_sort.py
Ruff (W293)
Check failure on line 26 in sorts/flash_sort.py
Ruff (PLR1730)
Check failure on line 28 in sorts/flash_sort.py
Ruff (PLR1730)
Check failure on line 31 in sorts/flash_sort.py
Ruff (W293)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file
sorts/flash_sort.py
, please provide doctest for the functionget_bucket_id
Check failure on line 38 in sorts/flash_sort.py
Ruff (W293)
Check failure on line 39 in sorts/flash_sort.py
Ruff (N806)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable and function names should follow the
snake_case
naming convention. Please update the following name accordingly:Lb
Check failure on line 42 in sorts/flash_sort.py
Ruff (W293)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file
sorts/flash_sort.py
, please provide doctest for the functionfind_swap_index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file
sorts/flash_sort.py
, please provide doctest for the functionarrange_bucket
Please provide return type hint for the function:
arrange_bucket
. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide descriptive name for the parameter:
b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file
sorts/flash_sort.py
, please provide doctest for the functioninsertion_sort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file
sorts/flash_sort.py
, please provide doctest for the functioninsertion_sort
Check failure on line 88 in sorts/flash_sort.py
Ruff (W292)