Add flash sort algorithm implementation #11970
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/flash_sort.py
Outdated
| def get_bucket_id(value: int) -> int: | ||
| return (m * (value - min_value)) // (max_value - min_value + 1) | ||
|
|
||
| Lb = [0] * m |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: Lb
sorts/flash_sort.py
Outdated
| Lb[i] += Lb[i - 1] | ||
|
|
||
| # Step 5: Rearrange the elements | ||
| def find_swap_index(b_id: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/flash_sort.py, please provide doctest for the function find_swap_index
sorts/flash_sort.py
Outdated
| break | ||
| return ind | ||
|
|
||
| def arrange_bucket(i1: int, i2: int, b: int): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/flash_sort.py, please provide doctest for the function arrange_bucket
Please provide return type hint for the function: arrange_bucket. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: b
sorts/flash_sort.py
Outdated
| arrange_bucket(Lb[b - 1], Lb[b], b) | ||
|
|
||
| # Step 6: Sort each bucket using insertion sort | ||
| def insertion_sort(sub_array: list[int]) -> list[int]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/flash_sort.py, please provide doctest for the function insertion_sort
algorithms-keeper
bot
added
awaiting reviews
algorithms-keeper
bot
removed
the
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
bot
removed
require tests
algorithms-keeper
bot
added
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
…orithm in flash_sort.py
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/flash_sort.py
Outdated
| m = max(math.floor(0.45 * n), 1) | ||
|
|
||
| # Step 3: Count the number of elements in each bucket | ||
| def get_bucket_id(value: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/flash_sort.py, please provide doctest for the function get_bucket_id
sorts/flash_sort.py
Outdated
| bucket_counts[i] += bucket_counts[i - 1] | ||
|
|
||
| # Step 5: Rearrange the elements | ||
| def find_swap_index(bucket_id: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/flash_sort.py, please provide doctest for the function find_swap_index
sorts/flash_sort.py
Outdated
| break | ||
| return ind | ||
|
|
||
| def arrange_bucket(i1: int, i2: int, bucket_id: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/flash_sort.py, please provide doctest for the function arrange_bucket
sorts/flash_sort.py
Outdated
| arrange_bucket(bucket_counts[bucket_id - 1], bucket_counts[bucket_id], bucket_id) | ||
|
|
||
| # Step 6: Sort each bucket using insertion sort | ||
| def insertion_sort(sub_array: list[int]) -> list[int]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/flash_sort.py, please provide doctest for the function insertion_sort
algorithms-keeper
bot
added
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/flash_sort.py
Outdated
|
|
||
|
|
||
| class FlashSort: | ||
| def __init__(self, arr: list[int], n_classes: int, sort_key: Callable[[int], int] = lambda x: x): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: x
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/flash_sort.py
Outdated
|
|
||
|
|
||
| class FlashSort: | ||
| def __init__(self, arr: list[int], n_classes: int, sort_key: Callable[[int], int] = lambda x: x): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: x
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/flash_sort.py
Outdated
|
|
||
|
|
||
| class FlashSort: | ||
| def __init__(self, arr: list[int], n_classes: int, sort_key: Callable[[int], int] = lambda x: x): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: x
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/flash_sort.py
Outdated
|
|
||
|
|
||
| class FlashSort: | ||
| def __init__(self, arr: list[int], n_classes: int, sort_key: Callable[[int], int] = lambda x: x): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: x
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/flash_sort.py
Outdated
| from collections.abc import Callable | ||
|
|
||
| class FlashSort: | ||
| def __init__(self, arr: list[int], n_classes: int, |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
sorts/flash_sort.py
Outdated
|
|
||
| class FlashSort: | ||
| def __init__(self, arr: list[int], n_classes: int, | ||
| sort_key: Callable[[int], int] = lambda x: x): |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/flash_sort.py
Outdated
| from collections.abc import Callable | ||
|
|
||
| class FlashSort: | ||
| def __init__(self, arr: list[int], n_classes: int, |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
sorts/flash_sort.py
Outdated
|
|
||
| class FlashSort: | ||
| def __init__(self, arr: list[int], n_classes: int, | ||
| sort_key: Callable[[int], int] = lambda x: x): |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
algorithms-keeper
bot
removed
require descriptive names
I001 Import block is un-sorted or un-formatted
|
Closing tests_are_failing PRs to prepare for Hacktoberfest |
Describe Your Change:
Checklist:
Explanation:
"This PR adds the implementation of the Flash Sort algorithm in
flash_sort.py. The algorithm utilizes a bucket-based approach to sort the elements efficiently. All necessary doctests are included, and the code follows the project's naming conventions and guidelines."