A* Searching Algorithm Added #11737
A* Searching Algorithm Added #11737
Conversation
algorithms-keeper
bot
added
the
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # Check if a cell is valid (within the grid) | ||
|
|
||
|
|
||
| def is_valid(row: int, col: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/A_star_search.py, please provide doctest for the function is_valid
| # Check if a cell is unblocked | ||
|
|
||
|
|
||
| def is_unblocked(grid: List[List[int]], row: int, col: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/A_star_search.py, please provide doctest for the function is_unblocked
| # Check if a cell is the destination | ||
|
|
||
|
|
||
| def is_destination(row: int, col: int, dest: Tuple[int, int]) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/A_star_search.py, please provide doctest for the function is_destination
| # Calculate the heuristic value of a cell (Euclidean distance to destination) | ||
|
|
||
|
|
||
| def calculate_h_value(row: int, col: int, dest: Tuple[int, int]) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/A_star_search.py, please provide doctest for the function calculate_h_value
| # Trace the path from source to destination | ||
|
|
||
|
|
||
| def trace_path(cell_details: List[List[Cell]], dest: Tuple[int, int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/A_star_search.py, please provide doctest for the function trace_path
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require tests
for more information, see https://pre-commit.ci
|
As stated in #11732, we already have multiple implementations of A*, and we don't want duplicate algorithms in our repo. Also, this code is clearly plagiarized from this GeeksforGeeks article. In your previous attempts at opening a PR, #11734 and #11735, the code is literally identical to the code in the article. Even your README text in those two PRs were plagiarized from the article. The only reason why this PR isn't also entirely identical is that you added type hints this time. You had checked these boxes in the PR description, so you did acknowledge these statements:
DO NOT PLAGIARIZE. WE WILL NOT ACCEPT PLAGIARIZED CODE. |
tianyizheng02
added
invalid
Plagiarism!!
fix #11732
Describe your change:
Checklist: